Project

General

Profile

« Previous | Next » 

Revision 48012

Added by Tsampikos Livisianos almost 7 years ago

prepared statements for the sql queries

View differences:

ClaimHandler.java
14 14

  
15 15
import java.sql.ResultSet;
16 16
import java.sql.SQLException;
17
import java.util.ArrayList;
17 18
import java.util.Date;
18 19
import java.util.List;
19 20

  
......
46 47
            }
47 48
        }
48 49
    }
49
   public String  generateSaveQueryForClaim(Claim claim){
50
   public String  generateSaveQueryForClaim(Claim claim, ArrayList<Object> params){
50 51

  
51 52
       String query= null;
52 53
       /*if (claim.getSourceType().equals(ClaimUtils.CONTEXT)) {
......
56 57
       } else{
57 58
           query = queryGenerator.generateInsertClaimResultQuery(resultHandler.generateSaveQueryForResult((Result)claim.getTarget()), resultHandler.generateSaveQueryForResult((Result) claim.getSource()), claim);
58 59
       }*/
59
       query = queryGenerator.generateInsertFullClaimQuery(claim);
60
       query = queryGenerator.generateInsertFullClaimQuery(claim, params);
60 61
       return query;
61 62
   }
62 63
    /**
......
68 69
    public String saveClaim(Claim claim) throws SQLStoreException, SQLException {
69 70
        logger.info("Saving claim...");
70 71
        String id = null;
71
        ResultSet rs=sqlDAO.executePreparedQuery(generateSaveQueryForClaim(claim));
72
        ArrayList<Object> params = new ArrayList<>();
73
        String query = generateSaveQueryForClaim(claim, params);
74
        ResultSet rs=sqlDAO.executePreparedQuery(query, params);
72 75
        if(rs.next()) {
73 76
            id = rs.getString(1);
74 77
        }
......
142 145

  
143 146
    }
144 147

  
145
    public boolean updateClaimCurationInfo(String curatedBy, String claimId, boolean approved) throws SQLStoreException, SQLException {
148
    public boolean updateClaimCurationInfo(String curatedBy, String claimId, boolean approved) throws SQLStoreException, SQLException, Exception {
146 149
        logger.info("Updating claim curation info...");
147
        ResultSet rs = sqlDAO.executePreparedQuery(queryGenerator.generateUpdateClaimCuration(curatedBy, claimId, approved));
150
        ArrayList<Object> params = new ArrayList<>();
151
        String query = queryGenerator.generateUpdateClaimCuration(curatedBy, claimId, approved, params);
152
        //ResultSet rs = sqlDAO.executeUpdateQuery(query, params);
153
        return sqlDAO.executeUpdateQuery(query, params);
148 154

  
155
        /*
149 156
        boolean success = false;
150 157
        while (rs.next())
151 158
        {
......
153 160
        }
154 161
        rs.close();
155 162
        return success;
163
        */
156 164
    }
157 165

  
158 166

  
......
243 251

  
244 252
    public void deleteClaim(String user, String claimId) throws SQLStoreException, Exception {
245 253

  
246
        ResultSet rs = sqlDAO.executePreparedQuery(queryGenerator.generateSelectClaimQuery(claimId,user));
254
        ArrayList<Object> params = new ArrayList<>();
255
        String query = queryGenerator.generateSelectClaimQuery(claimId,user, params);
256
        ResultSet rs = sqlDAO.executePreparedQuery(query, params);
247 257
        if(rs.next()) {
248 258
            String sourceType =rs.getString(2);
249 259
            String sourceId =rs.getString(3);
250 260
            String targetType =rs.getString(4);
251 261
            String targetId =rs.getString(5);
252
            sqlDAO.executeUpdateQuery(queryGenerator.generateDeleteFullClaimQuery(claimId,user,sourceType,sourceId,targetType,targetId));
262
            ArrayList<Object> params2 = new ArrayList<>();
263
            String query2 = queryGenerator.generateDeleteFullClaimQuery(claimId,user,sourceType,sourceId,targetType,targetId, params2);
264
            sqlDAO.executeUpdateQuery(query2, params2);
253 265
        }else{
254 266
            logger.error("Claim with id : "+ claimId+" user:  "+user+" couldn't be deleted." );
255 267
        }
......
258 270

  
259 271
    public boolean deleteClaim(String claimId) throws Exception, SQLStoreException {
260 272

  
261
        ResultSet rs = sqlDAO.executePreparedQuery(queryGenerator.generateSelectClaimQuery(claimId));
273
        ArrayList<Object> params = new ArrayList<>();
274
        String query = queryGenerator.generateSelectClaimQuery(claimId, params);
275
        ResultSet rs = sqlDAO.executePreparedQuery(query, params);
262 276
        if(rs.next()) {
263 277
            String sourceType =rs.getString(2);
264 278
            String sourceId =rs.getString(3);
265 279
            String targetType =rs.getString(4);
266 280
            String targetId =rs.getString(5);
267 281
            String user =rs.getString(6);
268
            sqlDAO.executeUpdateQuery(queryGenerator.generateDeleteFullClaimQuery(claimId,user,sourceType,sourceId,targetType,targetId));
282
            ArrayList<Object> params2 = new ArrayList<>();
283
            String query2 = queryGenerator.generateDeleteFullClaimQuery(claimId,user,sourceType,sourceId,targetType,targetId, params2);
284
            sqlDAO.executeUpdateQuery(query2, params2);
269 285
            rs.close();
270 286
            return  true;
271 287
        }

Also available in: Unified diff