Project

General

Profile

« Previous | Next » 

Revision 56610

do not log or propagate erroneous and potentially huge xml records. They might clog the information system

View differences:

OaiIterator.java
134 134
        try {
135 135
            doc = reader.read(new StringReader(xml));
136 136
        } catch (DocumentException e) {
137
            log.warn("Error parsing xml, I try to clean it: " + xml, e);
137
            log.warn("Error parsing xml, I try to clean it", e);
138 138
            final String cleaned = XmlCleaner.cleanAllEntities(xml);
139 139
            try {
140 140
                doc = reader.read(new StringReader(cleaned));
141 141
            } catch (DocumentException e1) {
142 142
                final String resumptionToken = extractResumptionToken(xml);
143 143
                if (resumptionToken == null)
144
                    throw new CollectorServiceException("Error parsing cleaned document:" + cleaned, e1);
144
                    throw new CollectorServiceException("Error parsing cleaned document", e1);
145 145
                return resumptionToken;
146 146
            }
147 147
        }

Also available in: Unified diff