Developers' Best Practices » History » Version 3
Claudio Atzori, 10/01/2014 10:31 AM
| 1 | 1 | Alessia Bardi | h1. Developers' Best Practices |
|---|---|---|---|
| 2 | |||
| 3 | 3 | Claudio Atzori | It is time for D-Net development teams to find a strategy to improve our developement work! |
| 4 | 1 | Alessia Bardi | |
| 5 | The introduction of Jenkins and Nexus helped a lot in terms of code management, but now it is time to establish a set of guidelines to better co-ordinate our teams. |
||
| 6 | The following best practices are inspired by CNR developers' common sense, so we do not assume they are written in stones and applies as they are also in your cases. |
||
| 7 | |||
| 8 | So, you are strongly invited to comment/update this wiki page, so that we can reach a consensus. |
||
| 9 | 3 | Claudio Atzori | |
| 10 | h2. Coding |
||
| 11 | |||
| 12 | Most of the D-Net modules have been migrated to from the old build system ant to maven. This implies some changes to the module directories and files, here's the migration guide: |
||
| 13 | http://ci.research-infrastructures.eu/public/docbook/MavenMigration.html |
||
| 14 | |||
| 15 | Maven compliant D-Net module structure: |
||
| 16 | |||
| 17 | <pre> |
||
| 18 | . |
||
| 19 | ├── pom.xml |
||
| 20 | ├── src |
||
| 21 | │ ├── main |
||
| 22 | │ │ ├── java |
||
| 23 | │ │ │ └── eu |
||
| 24 | │ │ │ └── dnetlib |
||
| 25 | │ │ └── resources |
||
| 26 | │ │ └── eu |
||
| 27 | │ │ └── dnetlib |
||
| 28 | │ └── test |
||
| 29 | │ ├── java |
||
| 30 | │ │ └── eu |
||
| 31 | │ │ └── dnetlib |
||
| 32 | │ └── resources |
||
| 33 | │ └── eu |
||
| 34 | │ └── dnetlib |
||
| 35 | └── target |
||
| 36 | └── classes |
||
| 37 | </pre> |
||
| 38 | |||
| 39 | Hint: consider to define the svn:ignore property, set on the module root |
||
| 40 | |||
| 41 | <pre> |
||
| 42 | cd <MODULE_NAME> |
||
| 43 | svn pe svn:ignore . |
||
| 44 | |||
| 45 | .classpath |
||
| 46 | .project |
||
| 47 | .settings |
||
| 48 | target |
||
| 49 | </pre> |
||
| 50 | 1 | Alessia Bardi | |
| 51 | h2. Branching |
||
| 52 | |||
| 53 | It is always recommended to create a new branch when performing heavy changes to a module, rather than directly into trunk. |
||
| 54 | |||
| 55 | 2 | Claudio Atzori | h2. Use CI: trust Jenkins! |
| 56 | 1 | Alessia Bardi | |
| 57 | The developer should clean the @.m2/repository/eu@ local repository from time to time to be sure that there are no modules installed locally. |
||
| 58 | |||
| 59 | Modules should be downloaded from Nexus in order to properly resolve dependencies. |
||
| 60 | |||
| 61 | h2. Release Best Practices |
||
| 62 | |||
| 63 | h3. When/Why releasing a module? |
||
| 64 | |||
| 65 | * Generally speaking a developer should release a module when the code is mature enough to be used by others. |
||
| 66 | * An early release should be available in case others are relying on a module that is currently under heavy development (i.e., frequent commits that imply frequent snapshot updates), in order to avoid blocking other development activities. |
||
| 67 | * Before updating an interface (e.g., service interfaces) or library (e.g., common and utilities modules) a developer MUST ENSURE there is a release of the current version. |
||
| 68 | |||
| 69 | h3. How to assign a release version number? |
||
| 70 | |||
| 71 | Before releasing a module, you must check which kinds of changes have been performed since the last release. |
||
| 72 | @svn log@ is your friend here :) . |
||
| 73 | Depending on the kind of changes you can decide to increase the artifact version according to the following guidelines: |
||
| 74 | * BIG CHANGES impact the MAJOR version number. Ex. @0.0.1 --> 1.0.0@ |
||
| 75 | ** Examples of big changes are: updates to service interfaces, shared libraries, new functionalities. |
||
| 76 | * MINOR CHANGES impact the MINOR version number. Ex. @1.2.5 --> 1.3.0@ |
||
| 77 | ** Examples of minor changes are: service internals, non-shared code and libraries, important bug fixes. |
||
| 78 | * BUG FIXES impact the BUILD version number. Ex. @1.4.2 --> 1.4.3@ |
||
| 79 | ** Examples are small bug fixes that do not affect other components |
||
| 80 | |||
| 81 | h3. How to release? |
||
| 82 | |||
| 83 | These are the steps for the release of a module, given that developer has a fresh checkout of the module to be released. |
||
| 84 | |||
| 85 | # Ensure that the module to be released and the modules depending on it compile fine on Jenkins (http://ci.research-infrastructures.eu/). |
||
| 86 | # Update and commit the version of the module (trunk) to be released according to the guidelines above. |
||
| 87 | This maven command can be helpful: |
||
| 88 | @mvn versions:set -DnewVersion={release_version}-SNAPSHOT@ |
||
| 89 | # Copy the trunk source code to a release branch: |
||
| 90 | @svn cp https://svn.driver.../modules/<MODULE_NAME>/trunk https://svn.driver.../modules/<MODULE_NAME>/releases/{release_version}@ |
||
| 91 | # Switch to the release branch: |
||
| 92 | @svn switch https://svn.driver.../modules/<MODULE_NAME>/releases/{release_version}@ |
||
| 93 | # A released module MUST depend and inherit ONLY from released modules. Therefore the pom.xml file MUST be updated as follows: |
||
| 94 | ## change the parent version to a released version. Current is 0.0.1-alpha. |
||
| 95 | ## change all snapshot dependencies to a released version. Ex. @0.2.3-SNAPSHOT --> 0.2.3@ |
||
| 96 | ## change the artifact version by removing the @-SNAPSHOT@ suffix. |
||
| 97 | # Commit the updated pom.xml. |
||
| 98 | # Ensure the module compiles: @mvn clean compile package -U@ |
||
| 99 | # Create the release build job on Jenkins (http://ci.research-infrastructures.eu/): |
||
| 100 | ## Select "New job" |
||
| 101 | ## Type in the name of the job as |
||
| 102 | @[module name]-release-[version]@. Ex. @dnet-runtime-release-0.0.9@ |
||
| 103 | ## Select "Create from existing job" and type in @dnet-svn-template-release@, then press OK |
||
| 104 | ## Modify the repository URL so that it matches the svn folder of the release branch |
||
| 105 | ## Save, enable the job, start the job, watch it compile, ensure it is deployed on nexus, disable the job again (an artifact on the dnet-release repository cannot be overwritten, hence we disable the job just to be sure they are not fired again by mistake). |
||
| 106 | |||
| 107 | Possibly a script will be made available to cover the points from 2 to 7. |