|
1
|
<?xml version="1.0" encoding="UTF-8"?>
|
|
2
|
<de:comments xmlns:de="http://de.tukl.softech.agileReview">
|
|
3
|
<de:author name="mafju"/>
|
|
4
|
<de:files>
|
|
5
|
<de:project name="icm-iis-collapsers">
|
|
6
|
<de:folder name="src">
|
|
7
|
<de:folder name="test">
|
|
8
|
<de:folder name="resources">
|
|
9
|
<de:folder name="eu">
|
|
10
|
<de:folder name="dnetlib">
|
|
11
|
<de:folder name="iis">
|
|
12
|
<de:folder name="collapsers">
|
|
13
|
<de:folder name="idreplacer">
|
|
14
|
<de:folder name="replacer_1_field">
|
|
15
|
<de:folder name="oozie_app">
|
|
16
|
<de:file name="workflow.xml">
|
|
17
|
<de:comment id="c0" author="mafju" reviewID="2014-04-23 IdReplacer with 2 IDs to replace" creation-date="2014-04-23T08:59:19.117+02:00" last-modified="2014-04-24T17:10:10.864+02:00" priority="0" recipient="micon" status="2" revision="0">
|
|
18
|
<de:text>The name of the working directory "collapsers_idreplacer" of the "replacer" workflow node/Ooize action should be replaced with "replacer" to match the name of the workflow node and conform to our conventions. The same thing's for the other replacer testing workflow.</de:text>
|
|
19
|
<de:replies/>
|
|
20
|
</de:comment>
|
|
21
|
</de:file>
|
|
22
|
</de:folder>
|
|
23
|
</de:folder>
|
|
24
|
</de:folder>
|
|
25
|
</de:folder>
|
|
26
|
</de:folder>
|
|
27
|
</de:folder>
|
|
28
|
</de:folder>
|
|
29
|
</de:folder>
|
|
30
|
</de:folder>
|
|
31
|
<de:folder name="main">
|
|
32
|
<de:folder name="java">
|
|
33
|
<de:folder name="eu">
|
|
34
|
<de:folder name="dnetlib">
|
|
35
|
<de:folder name="iis">
|
|
36
|
<de:folder name="collapsers">
|
|
37
|
<de:file name="IdReplacerUDF.java">
|
|
38
|
<de:comment id="c1" author="mafju" reviewID="2014-04-23 IdReplacer with 2 IDs to replace" creation-date="2014-04-23T12:57:15.715+02:00" last-modified="2014-04-24T17:31:12.762+02:00" priority="0" recipient="micon" status="2" revision="0">
|
|
39
|
<de:text>This seems to be a good idea. Can you talk with Dominika about it?</de:text>
|
|
40
|
<de:replies/>
|
|
41
|
</de:comment>
|
|
42
|
<de:comment id="c2" author="mafju" reviewID="2014-04-23 IdReplacer with 2 IDs to replace" creation-date="2014-04-23T13:06:12.796+02:00" last-modified="2014-04-24T17:40:49.938+02:00" priority="0" recipient="micon" status="2" revision="0">
|
|
43
|
<de:text>This and other methods below might be made static since they do not use any internal state of this object. To me, such a change would make the code a little bit clearer (and more similar to the functional programming approach ;) )</de:text>
|
|
44
|
<de:replies/>
|
|
45
|
</de:comment>
|
|
46
|
</de:file>
|
|
47
|
</de:folder>
|
|
48
|
</de:folder>
|
|
49
|
</de:folder>
|
|
50
|
</de:folder>
|
|
51
|
</de:folder>
|
|
52
|
<de:folder name="resources">
|
|
53
|
<de:folder name="eu">
|
|
54
|
<de:folder name="dnetlib">
|
|
55
|
<de:folder name="iis">
|
|
56
|
<de:folder name="collapsers">
|
|
57
|
<de:folder name="idreplacer">
|
|
58
|
<de:folder name="oozie_app">
|
|
59
|
<de:file name="workflow.xml">
|
|
60
|
<de:comment id="c3" author="mafju" reviewID="2014-04-23 IdReplacer with 2 IDs to replace" creation-date="2014-04-23T15:15:34.214+02:00" last-modified="2014-04-29T15:56:53.166+02:00" priority="0" recipient="micon" status="2" revision="0">
|
|
61
|
<de:text>To conform to our conventions, the name of property "schema_input" should be changed to "schema_input_main" since "main" is the name of the input port.</de:text>
|
|
62
|
<de:replies/>
|
|
63
|
</de:comment>
|
|
64
|
</de:file>
|
|
65
|
</de:folder>
|
|
66
|
</de:folder>
|
|
67
|
</de:folder>
|
|
68
|
</de:folder>
|
|
69
|
</de:folder>
|
|
70
|
</de:folder>
|
|
71
|
</de:folder>
|
|
72
|
</de:folder>
|
|
73
|
</de:folder>
|
|
74
|
</de:project>
|
|
75
|
</de:files>
|
|
76
|
</de:comments>
|